On 19.06.2023 17:49, Andrew Cooper wrote: > On 15/06/2023 4:48 pm, Alejandro Vallejo wrote: >> diff --git a/xen/arch/x86/cpu/microcode/core.c >> b/xen/arch/x86/cpu/microcode/core.c >> index e65af4b82e..df7e1df870 100644 >> --- a/xen/arch/x86/cpu/microcode/core.c >> +++ b/xen/arch/x86/cpu/microcode/core.c >> @@ -750,11 +750,12 @@ __initcall(microcode_init); >> @@ -860,6 +861,9 @@ int __init early_microcode_init(unsigned long >> *module_map, >> break; >> } >> >> + if ( ucode_ops.collect_cpu_info ) >> + ucode_ops.collect_cpu_info(); >> + > > I still think this wants to be the other side of "ucode loading fully > unavailable", just below. > > I'm confident it will result in easier-to-follow logic.
Yet wouldn't that be against the purpose of obtaining the ucode revision even if loading isn't possible? Jan
