On 16/05/18 16:29, Jan Beulich wrote: >>>> On 07.05.18 at 23:07, <janakarajan.natara...@amd.com> wrote: >>>> >> + s->avic_last_phy_id = avic_get_physical_id_entry(d, >> GET_xAPIC_ID(apic_id)); > You don't appear to read this value outside of this function. Please store > values in struct domain / struct vcpu only if you in fact read them, and > if their calculation isn't trivial. > > I also don't appear to understand the purpose of the "last" in the name.
s->avic_last_phy_id is not needed. It is a cached unchanging pointer into the physid table. Removing it will help clean up some of the later patches. Strictly speaking, I'm not sure this is true if we decide to permit a guest to update its local APIC ID, but we don't currently allow this and I see no benefit from supporting it. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
