Hi Jan, > -----Original Message----- > Subject: Re: [PATCH v2 10/10] x86emul: AVX512-FP16 testing > > Henry, > > On 03.04.2023 17:00, Jan Beulich wrote: > > Naming of some of the builtins isn't fully consistent with that of pre- > > existing ones, so there's a need for a new BR2() wrapper macro. > > > > With the tests providing some proof of proper functioning of the > > emulator code also enable use of the feature by guests, as there's no > > other infrastructure involved in enabling this ISA extension. > > > > Signed-off-by: Jan Beulich <[email protected]> > > --- > > v2: Add CHANGELOG.md entry. > > I notice I forgot to Cc you on this submission, with said addition. > May I ask for your ack (or otherwise), please?
Thanks for letting me know this (and also remembering the changelog entry)! My suggestion would be making the entry look like a complete sentence instead of the current form. But I also understand this is quite nitpicking so I will let you decide, either making it more readable or keeping its current form is fine with me, and if you want to improve the wording, you can do it on commit. So: Acked-by: Henry Wang <[email protected]> # CHANGELOG Kind regards, Henry > > Thanks, Jan > > > --- a/CHANGELOG.md > > +++ b/CHANGELOG.md > > @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog > > - Bus-lock detection, used by Xen to mitigate (by rate-limiting) the > > system > > wide impact of a guest misusing atomic instructions. > > - xl/libxl can customize SMBIOS strings for HVM guests. > > + - x86 AVX512-FP16 > > > > ## > [4.17.0](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE- > 4.17.0) - 2022-12-12 > > > >[...]
