On 05/06/2023 11:29 am, Bertrand Marquis wrote: > Hi Andrew, > >> On 5 Jun 2023, at 12:05, Andrew Cooper <[email protected]> wrote: >> >> Insecure the word being looked for here. Especially given the nature of the >> sole caller, and the (correct) comment next to it. > Good finding. > >> I've left the taint constant as 'U' as it's a rather more user-visible. > I would vote to change the U in I here as it will make it more coherent > with the doc after your added fix for it. > >> Fixes: 82c0d3d491cc ("xen: Add an unsecure Taint type") >> Signed-off-by: Andrew Cooper <[email protected]> >> --- >> CC: Jan Beulich <[email protected]> >> CC: Roger Pau Monné <[email protected]> >> CC: Wei Liu <[email protected]> >> CC: Stefano Stabellini <[email protected]> >> CC: Julien Grall <[email protected]> >> CC: Volodymyr Babchuk <[email protected]> >> CC: Bertrand Marquis <[email protected]> >> >> I'm happy to change 'U' to 'I' if we think that no-one is going to be >> impacted >> by it. I just wasn't sure. > Here i do not think many will be impacted so I would rather make this > coherent.
Ok. I'll submit a v2 with everything adjusted. ~Andrew
