On 05.06.2023 07:28, Roberto Bagnara wrote: > Finally, Xen seems to rely on explicitly undefined behavior, namely > C99 UB 58: "A structure or union is defined as containing no named > members (6.7.2.1)." All instances but one occur via macro BUILD_BUG_ON_ZERO, > the remaining instance concerns struct > `cpu_policy::<anonymous union>::<anonymous struct>::<anonymous > union>::<anonymous struct>'. > Reliance on undefined behavior might be hard to justify.
For starters just a comment here: I'm pretty sure this case was discussed before, and that it was agreed that if need be we'd simply add _ as the name there. Yet then - how did you notice this? Code inspection? I would expect no analysis tool would spot it because it's used for gcc < 4.6 only. And I doubt you run analysis tools in combination with this old a gcc? Jan
