On 30/05/2023 10:07 am, Jan Beulich wrote: > On 26.05.2023 13:06, Andrew Cooper wrote: >> This is prep work, split out to simply the diff on the following change. >> >> * Rename to retpoline_calculations(), and call unconditionally. It is >> shortly going to synthesize missing enumerations required for guest >> safety. >> * For Broadwell, store the ucode revision calculation in a variable and fall >> out of the bottom of the switch statement. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Jan Beulich <jbeul...@suse.com>
Thanks. > > I guess subsequent patches will teach me why ... > >> @@ -681,6 +682,12 @@ static bool __init retpoline_safe(void) >> boot_cpu_data.x86_model); >> return false; >> } >> + >> + /* Only Broadwell gets here. */ >> + if ( safe ) >> + return true; >> + >> + return false; > ... this isn't just "return safe;". Indeed they will. ~Andrew
