On 23.05.2023 18:38, Anthony PERARD wrote: > --- a/xen/xsm/flask/Makefile > +++ b/xen/xsm/flask/Makefile > @@ -48,10 +48,15 @@ targets += flask-policy.S > FLASK_BUILD_DIR := $(abs_objtree)/$(obj) > POLICY_SRC := $(FLASK_BUILD_DIR)/xenpolicy-$(XEN_FULLVERSION) > > +policy_chk = \ > + $(Q)if ! cmp -s $(POLICY_SRC) $@; then \ > + $(kecho) ' UPD $@'; \ > + cp $(POLICY_SRC) $@; \
Wouldn't this better use move-if-changed? Which, if "UPD ..." output is desired, would then need overriding from what Config.mk supplies? In any event, much like move-if-changed itself - please avoid underscores in names when dashes are fine to use. > + fi > $(obj)/policy.bin: FORCE Nit: Blank line above here please. Jan > - $(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common \ > + $(Q)$(MAKE) -f $(XEN_ROOT)/tools/flask/policy/Makefile.common \ > -C $(XEN_ROOT)/tools/flask/policy \ > FLASK_BUILD_DIR=$(FLASK_BUILD_DIR) POLICY_FILENAME=$(POLICY_SRC) > - cmp -s $(POLICY_SRC) $@ || cp $(POLICY_SRC) $@ > + $(call policy_chk) > > clean-files := policy.* $(POLICY_SRC)
