On Fri, May 12, 2023 at 12:26:14PM +0000, Olaf Hering wrote: > According to openpty(3) it is required to include <pty.h> to get the > prototypes for openpty() and login_tty(). But this is not what the > function AX_CHECK_PTYFUNCS actually does. It makes no attempt to include > the required header. > > The two source files which call openpty() and login_tty() already contain > the conditionals to include the required header. > > Remove the bogus m4 file to fix build with clang, which complains about > calls to undeclared functions. > > Remove usage of INCLUDE_LIBUTIL_H in libxl_bootloader.c, it is already > covered by inclusion of libxl_osdep.h. > > Remove usage of PTYFUNCS_LIBS in libxl/Makefile, it is already covered > by UTIL_LIBS from config/StdGNU.mk. > > Signed-off-by: Olaf Hering <o...@aepfle.de>
Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> Obviously, the committer will have to run ./autogen.sh before committing. Thanks, -- Anthony PERARD
