On 10.05.2023 16:20, Yann Dirson wrote: > --- a/docs/misc/xenstore-paths.pandoc > +++ b/docs/misc/xenstore-paths.pandoc > @@ -509,6 +509,12 @@ This may be initialized to "" by the toolstack and may > then be set > to 0 or 1 by a guest to indicate whether it is capable of responding > to a mode value written to ~/control/laptop-slate-mode. > > +#### ~/control/feature-balloon > + > +This may be initialized to "" by the toolstack and may then be set to > +0 or 1 by a guest to indicate whether it is capable of memory > +ballooning, and responds to values written to ~/memory/target.
Besides correctly saying "may", I guess this wants to go further and also clarify what the (intended) behavior is when the node is absent. Aiui PV guests are always expected to have a balloon driver, so the assumed value likely needs to be "1" there. Furthermore I'm afraid it doesn't really become clear what value this node is if it's only optionally present, while its absence doesn't really allow uniform assumptions towards a default value. Jan
