The latter is more legible, and consistent with X86_NR_{CAPS,SYNTH,BUG} which
already exist.
No functional change.
Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
---
CC: Jan Beulich <jbeul...@suse.com>
CC: Roger Pau Monné <roger....@citrix.com>
CC: Wei Liu <w...@xen.org>
---
xen/arch/x86/cpu-policy.c | 22 +++++++++++-----------
xen/arch/x86/cpu/common.c | 4 ++--
xen/arch/x86/include/asm/cpufeatures.h | 8 ++++----
xen/arch/x86/include/asm/cpuid.h | 2 +-
xen/arch/x86/sysctl.c | 8 ++++----
5 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/xen/arch/x86/cpu-policy.c b/xen/arch/x86/cpu-policy.c
index 44c88debf958..774c512a03bd 100644
--- a/xen/arch/x86/cpu-policy.c
+++ b/xen/arch/x86/cpu-policy.c
@@ -130,8 +130,8 @@ static int __init cf_check parse_xen_cpuid(const char *s)
custom_param("cpuid", parse_xen_cpuid);
static bool __initdata dom0_cpuid_cmdline;
-static uint32_t __initdata dom0_enable_feat[FSCAPINTS];
-static uint32_t __initdata dom0_disable_feat[FSCAPINTS];
+static uint32_t __initdata dom0_enable_feat[X86_NR_FEAT];
+static uint32_t __initdata dom0_disable_feat[X86_NR_FEAT];
static void __init cf_check _parse_dom0_cpuid(unsigned int feat, bool val)
{
@@ -158,10 +158,10 @@ static void sanitise_featureset(uint32_t *fs)
{
/* for_each_set_bit() uses unsigned longs. Extend with zeroes. */
uint32_t disabled_features[
- ROUNDUP(FSCAPINTS, sizeof(unsigned long)/sizeof(uint32_t))] = {};
+ ROUNDUP(X86_NR_FEAT, sizeof(unsigned long)/sizeof(uint32_t))] = {};
unsigned int i;
- for ( i = 0; i < FSCAPINTS; ++i )
+ for ( i = 0; i < X86_NR_FEAT; ++i )
{
/* Clamp to known mask. */
fs[i] &= known_features[i];
@@ -181,7 +181,7 @@ static void sanitise_featureset(uint32_t *fs)
ASSERT(dfs); /* deep_features[] should guarentee this. */
- for ( j = 0; j < FSCAPINTS; ++j )
+ for ( j = 0; j < X86_NR_FEAT; ++j )
{
fs[j] &= ~dfs[j];
disabled_features[j] &= ~dfs[j];
@@ -476,7 +476,7 @@ static void __init
guest_common_feature_adjustments(uint32_t *fs)
static void __init calculate_pv_max_policy(void)
{
struct cpu_policy *p = &pv_max_cpu_policy;
- uint32_t fs[FSCAPINTS];
+ uint32_t fs[X86_NR_FEAT];
unsigned int i;
*p = host_cpu_policy;
@@ -509,7 +509,7 @@ static void __init calculate_pv_max_policy(void)
static void __init calculate_pv_def_policy(void)
{
struct cpu_policy *p = &pv_def_cpu_policy;
- uint32_t fs[FSCAPINTS];
+ uint32_t fs[X86_NR_FEAT];
unsigned int i;
*p = pv_max_cpu_policy;
@@ -529,7 +529,7 @@ static void __init calculate_pv_def_policy(void)
static void __init calculate_hvm_max_policy(void)
{
struct cpu_policy *p = &hvm_max_cpu_policy;
- uint32_t fs[FSCAPINTS];
+ uint32_t fs[X86_NR_FEAT];
unsigned int i;
const uint32_t *mask;
@@ -625,7 +625,7 @@ static void __init calculate_hvm_max_policy(void)
static void __init calculate_hvm_def_policy(void)
{
struct cpu_policy *p = &hvm_def_cpu_policy;
- uint32_t fs[FSCAPINTS];
+ uint32_t fs[X86_NR_FEAT];
unsigned int i;
const uint32_t *mask;
@@ -723,7 +723,7 @@ void recalculate_cpuid_policy(struct domain *d)
const struct cpu_policy *max = is_pv_domain(d)
? (IS_ENABLED(CONFIG_PV) ? &pv_max_cpu_policy : NULL)
: (IS_ENABLED(CONFIG_HVM) ? &hvm_max_cpu_policy : NULL);
- uint32_t fs[FSCAPINTS], max_fs[FSCAPINTS];
+ uint32_t fs[X86_NR_FEAT], max_fs[X86_NR_FEAT];
unsigned int i;
if ( !max )
@@ -864,7 +864,7 @@ void __init init_dom0_cpuid_policy(struct domain *d)
/* Apply dom0-cpuid= command line settings, if provided. */
if ( dom0_cpuid_cmdline )
{
- uint32_t fs[FSCAPINTS];
+ uint32_t fs[X86_NR_FEAT];
unsigned int i;
x86_cpu_policy_to_featureset(p, fs);
diff --git a/xen/arch/x86/cpu/common.c b/xen/arch/x86/cpu/common.c
index 1be049e332ce..d12ccea20350 100644
--- a/xen/arch/x86/cpu/common.c
+++ b/xen/arch/x86/cpu/common.c
@@ -80,7 +80,7 @@ void __init setup_clear_cpu_cap(unsigned int cap)
if (!dfs)
return;
- for (i = 0; i < FSCAPINTS; ++i) {
+ for (i = 0; i < X86_NR_FEAT; ++i) {
cleared_caps[i] |= dfs[i];
boot_cpu_data.x86_capability[i] &= ~dfs[i];
if (!(forced_caps[i] & dfs[i]))
@@ -527,7 +527,7 @@ void identify_cpu(struct cpuinfo_x86 *c)
* The vendor-specific functions might have changed features. Now
* we do "generic changes."
*/
- for (i = 0; i < FSCAPINTS; ++i)
+ for (i = 0; i < X86_NR_FEAT; ++i)
c->x86_capability[i] &= known_features[i];
for (i = 0 ; i < X86_NR_CAPS ; ++i) {
diff --git a/xen/arch/x86/include/asm/cpufeatures.h
b/xen/arch/x86/include/asm/cpufeatures.h
index e982ee920ce1..408ab4ba16a5 100644
--- a/xen/arch/x86/include/asm/cpufeatures.h
+++ b/xen/arch/x86/include/asm/cpufeatures.h
@@ -5,11 +5,11 @@
#include <xen/lib/x86/cpuid-autogen.h>
/* Number of capability words covered by the featureset words. */
-#define FSCAPINTS FEATURESET_NR_ENTRIES
+#define X86_NR_FEAT FEATURESET_NR_ENTRIES
/* Synthetic words follow the featureset words. */
#define X86_NR_SYNTH 1
-#define X86_SYNTH(x) (FSCAPINTS * 32 + (x))
+#define X86_SYNTH(x) (X86_NR_FEAT * 32 + (x))
/* Synthetic features */
XEN_CPUFEATURE(CONSTANT_TSC, X86_SYNTH( 0)) /* TSC ticks at a constant
rate */
@@ -45,7 +45,7 @@ XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /*
MSR_PRED_CMD used by Xen for
/* Bug words follow the synthetic words. */
#define X86_NR_BUG 1
-#define X86_BUG(x) ((FSCAPINTS + X86_NR_SYNTH) * 32 + (x))
+#define X86_BUG(x) ((X86_NR_FEAT + X86_NR_SYNTH) * 32 + (x))
#define X86_BUG_FPU_PTRS X86_BUG( 0) /* (F)X{SAVE,RSTOR} doesn't
save/restore FOP/FIP/FDP. */
#define X86_BUG_NULL_SEG X86_BUG( 1) /* NULL-ing a selector preserves
the base and limit. */
@@ -53,4 +53,4 @@ XEN_CPUFEATURE(IBPB_ENTRY_HVM, X86_SYNTH(29)) /*
MSR_PRED_CMD used by Xen for
#define X86_BUG_IBPB_NO_RET X86_BUG( 3) /* IBPB doesn't flush the
RSB/RAS */
/* Total number of capability words, inc synth and bug words. */
-#define X86_NR_CAPS (FSCAPINTS + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit words
worth of info */
+#define X86_NR_CAPS (X86_NR_FEAT + X86_NR_SYNTH + X86_NR_BUG) /* N 32-bit
words worth of info */
diff --git a/xen/arch/x86/include/asm/cpuid.h b/xen/arch/x86/include/asm/cpuid.h
index b32ba0bbfe5c..85b6ca0edb91 100644
--- a/xen/arch/x86/include/asm/cpuid.h
+++ b/xen/arch/x86/include/asm/cpuid.h
@@ -10,7 +10,7 @@
#include <public/sysctl.h>
-extern const uint32_t known_features[FSCAPINTS];
+extern const uint32_t known_features[X86_NR_FEAT];
/*
* Expected levelling capabilities (given cpuid vendor/family information),
diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c
index c107f40c6283..9be0e796628c 100644
--- a/xen/arch/x86/sysctl.c
+++ b/xen/arch/x86/sysctl.c
@@ -308,13 +308,13 @@ long arch_do_sysctl(
#endif
};
const struct cpu_policy *p = NULL;
- uint32_t featureset[FSCAPINTS];
+ uint32_t featureset[X86_NR_FEAT];
unsigned int nr;
/* Request for maximum number of features? */
if ( guest_handle_is_null(sysctl->u.cpu_featureset.features) )
{
- sysctl->u.cpu_featureset.nr_features = FSCAPINTS;
+ sysctl->u.cpu_featureset.nr_features = X86_NR_FEAT;
if ( __copy_field_to_guest(u_sysctl, sysctl,
u.cpu_featureset.nr_features) )
ret = -EFAULT;
@@ -323,7 +323,7 @@ long arch_do_sysctl(
/* Clip the number of entries. */
nr = min_t(unsigned int, sysctl->u.cpu_featureset.nr_features,
- FSCAPINTS);
+ X86_NR_FEAT);
/* Look up requested featureset. */
if ( sysctl->u.cpu_featureset.index < ARRAY_SIZE(policy_table) )
@@ -352,7 +352,7 @@ long arch_do_sysctl(
ret = -EFAULT;
/* Inform the caller if there was more data to provide. */
- if ( !ret && nr < FSCAPINTS )
+ if ( !ret && nr < X86_NR_FEAT )
ret = -ENOBUFS;
break;
--
2.30.2
