On 03/05/2023 14:08, Julien Grall wrote: > > > Hi, > > On 28/04/2023 18:55, Ayan Kumar Halder wrote: >> In the callback functions invoked by dt_for_each_range() ie >> handle_pci_range(), >> map_range_to_domain(), 'u64' should be replaced with 'uint64_t' as the data >> type >> for the parameters. > > Please explain why this needs to be replaced. I.e. Xen coding style > mention that u32 should be avoided. > >> Also dt_for_each_range() invokes the callback functions with >> 'uint64_t' arguments. >> >> There is another callback function ie is_bar_valid() which uses 'paddr_t' >> instead of 'u64' or 'uint64_t'. We will change it in the subsequent commit. > > I would rather prefer if this is folded in this patch. > With the Julien's comments fixed: Reviewed-by: Michal Orzel <michal.or...@amd.com>
~Michal
