On Wed, May 03, 2023 at 05:33:05PM +0200, Jan Beulich wrote:
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -438,12 +438,14 @@ struct domain
>  
>      struct grant_table *grant_table;
>  
> +#ifdef CONFIG_HAS_PIRQ
>      /*
>       * Interrupt to event-channel mappings and other per-guest-pirq data.
>       * Protected by the domain's event-channel spinlock.
>       */
>      struct radix_tree_root pirq_tree;
>      unsigned int     nr_pirqs;
> +#endif

Won't it be cleaner to just move this into arch_domain and avoid a
bunch of the ifdefary? As the initialization of the fields would be
moved to arch_domain_create() also.

Maybe we would want to introduce some kind of arch-specific event
channel handler so that the bind PIRQ hypercall could be handled
there?

Thanks, Roger.

Reply via email to