On 01.05.2023 22:03, Stewart Hildebrand wrote: > @@ -228,6 +229,9 @@ int iommu_release_dt_devices(struct domain *d); > * (IOMMU is not enabled/present or device is not connected to it). > */ > int iommu_add_dt_device(struct dt_device_node *np); > +#ifdef CONFIG_HAS_PCI > +int iommu_add_dt_pci_device(uint8_t devfn, struct pci_dev *pdev); > +#endif
Why the first parameter? Doesn't the 2nd one describe the device in full? If this is about phantom devices, then I'd expect the function to take care of those (like iommu_add_device() does), rather than its caller. Jan