On 17.04.2023 11:58, Andrew Cooper wrote: > The ro_pages + rw_pages + text_pages != payload->pages check is not something > which is reasonable to skip at runtime. Rewrite it to not be an ASSERT().
Isn't this merely a sanity check? IOW isn't returning -EINVAL in this case misleading, as to calling "invalid input" what really is an internal error in Xen? But anyway, I guess I'll leave this to the maintainers. > As the code is being shuffled anyway, rework the logic calling > arch_livepatch_secure() to reduce its verbosity. By "verbosity", dym lines of code? Jan