Hi Jens, > -----Original Message----- > Subject: [XEN PATCH v8 04/22] xen/arm: ffa: add remaining SMC function IDs > > Adds the remaining SMC function IDs from FF-A 1.1 specification.
Nit: I would suggest that in commit message you can mention the documentation number you used. During my review of this patch I am using DEN0077A version 1.1 REL0. > > Signed-off-by: Jens Wiklander <jens.wiklan...@linaro.org> > Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com> I also confirm that the macro values introduced by this patch is consistent with the spec in commit message, hence: Reviewed-by: Henry Wang <henry.w...@arm.com> Kind regards, Henry