On 03/03/2023 2:55 pm, Anthony PERARD wrote: > From: Andrew Cooper <[email protected]> > > It has not been a dependency since at least 4.13. Remove its mandatory check > from ./configure. > > Annotate the dependency in the CI dockerfiles, and drop them from CirrusCI and > TravisCI. > > Signed-off-by: Andrew Cooper <[email protected]> > Acked-by: Roger Pau Monné <[email protected]> > (cherry picked from commit e21a6a4f966a7e91cb0bb014dbe15d15cc0502ad) > --- > > Notes: > As we dropped "gettext" from many containers, build on staging-4.15 > starts to fail due to unmet dependency. But that dependency isn't needed, > but configure hasn't been updated. > > pipeline with many fail due to missing gettext: > https://gitlab.com/xen-project/xen/-/pipelines/793302203 > > pipeline with that patch backported: > > https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/794335026 > still several build failure, but less, and not due to configure step > failing. > > Commit can be cherry-picked cleanly to staging-4.15. > > That commit would be needed as well on staging-4.14, but it doesn't > apply cleanly due to change in configure, and missing dockerfiles.
Urgh - I'm sorry about this. I'd completely forgotten about this mess. We do need to get CI working reliably, even on all old branches, so we do need to backport this too. But looking at the diffstat below, I think we also want to backport other things too (the change removing Travis), and I'm not sure we want to re-add the dockerfile comment seeing as we've already dropped it and rebuilt them all, and this patch is the one that stops it being mandatory. That would simplify this patch a lot, and make it applicable to 4.14 too, I think. Jan - are you happy for Anthony and I to just go free reign on the older branches until we've got testing into a working state? ~Andrew
