On 02/03/2023 1:23 pm, Oleksii Kurochko wrote: > Disable FPU to detect illegal usage of floating point in kernel > space. > > Signed-off-by: Oleksii Kurochko <[email protected]> > --- > Changes since v1: > * Rebase on top of two previous patches. > ---
Apologies - I meant to ask these on the previous series, but didn't get around to it. Why do we disable interrupts at the very start of start(), but only disable the FPU at the start of C ? To start with, doesn't OpenSBI have a starting ABI spec? What does that say on the matter of the enablement of these features on entry into the environment? Either way, my gut feeling is that these disables (if necessary to begin with) should be together, rather than split like this. That aside, while I can see the value of checking this now, won't we have to delete this again in order to allow for context switching a vCPUs FPU register state? ~Andrew
