On 23.02.2023 13:22, Andrew Cooper wrote: > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -31,7 +31,7 @@ > > #define __weak __attribute__((__weak__)) > > -#if !defined(__clang__) > +#if !CONFIG_CC_IS_CLANG || CONFIG_CLANG_VERSION >= 140000
Hmm, for the sake of getting the functional change in, Reviewed-by: Jan Beulich <jbeul...@suse.com> but this clearly is against the Kconfig usage proposal: Following that, such conditionals should not reference CONFIG_*, as the .config may have been generated not only with a different Clang version, but also with gcc instead of Clang. While there were a couple of comments, no counter proposal appeared so far, there was one explicit agreement with the proposal, and the requested patch demonstrating the intentions wasn't commented on either. One might conclude that as per our lazy consensus approach the proposal holds, and no such new uses violating its principles should be introduced. The more that the same can easily be expressed differently. Jan
