On 22.02.2023 13:00, Xenia Ragiadakou wrote: > Create a new private header in arch/x86/hvm/svm called svm.h and move there > all definitions and declarations that are used solely by svm code. > > The function svm_invlpga() stays in arch/x86/hvm/svm/svm.h because it is used > by arch/x86/hvm/svm/asid.h. > > Signed-off-by: Xenia Ragiadakou <burzalod...@gmail.com>
Acked-by: Jan Beulich <jbeul...@suse.com> > Changes in v2: > - new patch, the creation of a private header was suggested by Andrew and Jan Same remark here as on patch 2. > I have not added #ifndef guards as it is a private and it should not be > included by other headers. However, this is considered a MISRA-C violation > ... I 'm not sure what to do. Personally I prefer the guard-less form, but since Misra insists, we may better add them from the start. Besides being a little bit of clutter they're harmless, after all. My ack stands with or without the addition, but I wouldn't want to add them "while committing". So I guess we want to wait a little for further views, and then either commit as is or wait for a v3 with the guards added. Jan
