Hi Juergen,
On 20/01/2023 10:00, Juergen Gross wrote:
The accounting for the number of nodes of a domain in an active
transaction is not working correctly, as it allows to create arbitrary
number of nodes. The transaction will finally fail due to exceeding
the number of nodes quota, but before closing the transaction an
unprivileged guest could cause Xenstore to use a lot of memory.
I know I said I would delay my decision on this patch. However, I was
still expecting the commit message to be updated based on our previous
discussion.
Also thinking more about it, "The transaction will finally fail due to
exceeding the number of nodes quota" may not be true for a couple of
reasons:
1) The transaction may removed a node afterwards.
2) A node may have been removed outside of the transaction.
In both situation, the transaction will still be committed. This will
now be prevented by this patch.
While I understand, they may be edge cases, this is also true for what
you are aiming to solve. So I am still not convinced about the benefits
of this patch.
Cheers,
--
Julien Grall
