On 08.02.2023 05:51, Demi Marie Obenour wrote:
> --- a/stubdom/grub.patches/10graphics.diff
> +++ b/stubdom/grub.patches/10graphics.diff
> @@ -1187,7 +1187,7 @@ diff -Naur grub-0.97.orig/stage2/graphics.c 
> grub-0.97/stage2/graphics.c
>  + *  GNU General Public License for more details.
>  + *
>  + *  You should have received a copy of the GNU General Public License
> -+ *  along with this program; If not, see <http://www.gnu.org/licenses/>
> ++ *  along with this program; If not, see <https://www.gnu.org/licenses/>
>  + */

While this one may be seen as simply on the edge, ...

> --- a/tools/examples/xeninfo.pl
> +++ b/tools/examples/xeninfo.pl
> @@ -36,7 +36,7 @@ sub apiconnect
>  {
>       foreach my $xenhost (keys %xenhosts)
>       {
> -             my $xen = 
> RPC::XML::Client->new("http://$xenhost:$xenhosts{$xenhost}{'port'}");
> +             my $xen = 
> RPC::XML::Client->new("https://$xenhost:$xenhosts{$xenhost}{'port'}");
>               my $session = 
> $xen->simple_request("session.login_with_password", "user","");
>               if (! $session)
>               {

... this pretty clearly isn't part of the build system. And iirc Anthony
had put under question this change anyway.

> --- a/tools/firmware/etherboot/Makefile
> +++ b/tools/firmware/etherboot/Makefile
> @@ -5,9 +5,9 @@ include $(XEN_ROOT)/tools/Rules.mk
>  include Config
>  
>  ifeq ($(GIT_HTTP),y)
> -IPXE_GIT_URL ?= http://git.ipxe.org/ipxe.git
> +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git
>  else
> -IPXE_GIT_URL ?= git://git.ipxe.org/ipxe.git
> +IPXE_GIT_URL ?= https://git.ipxe.org/ipxe.git
>  endif

When both URLs are the same now, why keep the ifeq()?

Jan

Reply via email to