> On 3 Feb 2023, at 19:09, Xenia Ragiadakou <burzalod...@gmail.com> wrote:
>
I’m not really a supporter of empty commit message, but it’s up to the
maintainer :)
For me the changes looks good
Reviewed-by: Luca Fancellu <luca.fance...@arm.com>
> Signed-off-by: Xenia Ragiadakou <burzalod...@gmail.com>
> ---
>
> Changes in v3:
> - the fixes are based solely to Eclair findings (the tool has been
> adjusted to report only those violations that can result to a bug)
> - reflect this in the commit title
>
> xen/include/xen/device_tree.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h
> index a28937d12ae8..7839a199e311 100644
> --- a/xen/include/xen/device_tree.h
> +++ b/xen/include/xen/device_tree.h
> @@ -37,11 +37,11 @@ struct dt_device_match {
> const void *data;
> };
>
> -#define __DT_MATCH_PATH(p) .path = p
> -#define __DT_MATCH_TYPE(typ) .type = typ
> -#define __DT_MATCH_COMPATIBLE(compat) .compatible = compat
> +#define __DT_MATCH_PATH(p) .path = (p)
> +#define __DT_MATCH_TYPE(typ) .type = (typ)
> +#define __DT_MATCH_COMPATIBLE(compat) .compatible = (compat)
> #define __DT_MATCH_NOT_AVAILABLE() .not_available = 1
> -#define __DT_MATCH_PROP(p) .prop = p
> +#define __DT_MATCH_PROP(p) .prop = (p)
>
> #define DT_MATCH_PATH(p) { __DT_MATCH_PATH(p) }
> #define DT_MATCH_TYPE(typ) { __DT_MATCH_TYPE(typ) }
> @@ -226,13 +226,13 @@ dt_find_interrupt_controller(const struct
> dt_device_match *matches);
> #define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1
>
> #define dt_for_each_property_node(dn, pp) \
> - for ( pp = dn->properties; pp != NULL; pp = pp->next )
> + for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next )
>
> #define dt_for_each_device_node(dt, dn) \
> - for ( dn = dt; dn != NULL; dn = dn->allnext )
> + for ( dn = dt; (dn) != NULL; dn = (dn)->allnext )
>
> #define dt_for_each_child_node(dt, dn) \
> - for ( dn = dt->child; dn != NULL; dn = dn->sibling )
> + for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling )
>
> /* Helper to read a big number; size is in cells (not bytes) */
> static inline u64 dt_read_number(const __be32 *cell, int size)
> --
> 2.37.2
>
>
