On 2/6/23 15:11, Xenia Ragiadakou wrote:
On 2/6/23 15:01, Jan Beulich wrote:
On 06.02.2023 13:42, Xenia Ragiadakou wrote:
--- a/xen/arch/x86/emul-i8254.c
+++ b/xen/arch/x86/emul-i8254.c
@@ -34,7 +34,7 @@
#include <asm/time.h>
#include <asm/hvm/hvm.h>
#include <asm/hvm/io.h>
-#include <asm/hvm/support.h>
+#include <asm/hvm/save.h>
#include <asm/hvm/vpt.h>
#include <asm/current.h>
To be honest I'd prefer if only the HVM-specific part of this file had
this new #include (and ideally the other hvm/ ones would move there as
well, but I can see this being beyond the scope of what you're wanting
to do).
Ah I see. That's ok. I ll move it in v2.
After having a closer look at the code, I think it would be better to
leave it as is in this patch because the struct hvm_hw_pit_channel
(declared in puplic/hvm/save.h) and the function hvm_get_guest_time()
(declared in asm/hvm/hvm.h) are used by the common part of this file.
And I can send another patch to cleanup the headers in this file.
Unless you insist.
Jan
--
Xenia
