On 26.01.23 13:42, Jan Beulich wrote:
On 26.01.2023 13:24, Juergen Gross wrote:When loading a Xenstore stubdom the loader doesn't know whether the lo be loaded kernel is a PVH or a PV one. So it tries to load it as a PVH one first, and if this fails it is loading it as a PV kernel.This results in errors being logged in case the stubdom is a PV kernel. Suppress those errors by setting the minimum logging level to "critical" while trying to load the kernel as PVH.And if the PV loading also fails and PVH was actually expected, then the messages will be heavily misleading? Shouldn't you instead accumulate the PVH messages, and throw them away only in case PV loading actually worked (or issue them at lower severity, in case they're actually of interest)?
I think this would add a lot of code for little gain. What I could do is to repeat the PVH load attempt with full logging if the PV load fails, too. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature