On Thu, 2023-01-19 at 16:43 +0100, Jan Beulich wrote: > On 19.01.2023 15:29, Jan Beulich wrote: > > On 19.01.2023 15:07, Oleksii Kurochko wrote: > > > In the patch "include/types: move stddef.h-kind types to common > > > header" [1] size_t was moved from <asm/types.h> to <xen/types.h> > > > so early_printk should be updated correspondingly. > > > > Hmm, this reads a little like that patch would introduce a build > > issue (on Arm), but according to my testing it doesn't. If it did, > > the change here would need to be part of that (not yet committed) > > change. On the assumption that it really doesn't, ... > > > > > [1] > > > https://lore.kernel.org/xen-devel/5a0a9e2a-c116-21b5-8081-db75fe417...@suse.com/ > > > > > > Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> > > > > Acked-by: Jan Beulich <jbeul...@suse.com> > > Actually I notice we have more explicit uses of asm/types.h, and > hence the title of this change isn't really correct (with this It's really uncorrect. I was in a hurry, my fault. I meant that change <asm/types.h> to <xen/types.h> only for <xen/early_printk.h>.
> title I would expect all uses to go away underneath xen/include/xen). > I'll try to remember to adjust the title when committing. > Thanks for that. > Jan > ~ Oleksii
