On 17.01.2023 18:43, Ayan Kumar Halder wrote: > --- a/xen/arch/arm/include/asm/types.h > +++ b/xen/arch/arm/include/asm/types.h > @@ -37,9 +37,16 @@ typedef signed long long s64; > typedef unsigned long long u64; > typedef u32 vaddr_t; > #define PRIvaddr PRIx32 > +#if defined(CONFIG_ARM_PA_32) > +typedef u32 paddr_t; > +#define INVALID_PADDR (~0UL) > +#define PADDR_SHIFT BITS_PER_LONG > +#define PRIpaddr PRIx32 > +#else
With our plan to consolidate basic type definitions into xen/types.h the use of ARM_PA_32 is problematic: Preferably we'd have an arch- independent Kconfig setting, much like Linux'es PHYS_ADDR_T_64BIT (I don't think we should re-use the name directly, as we have no phys_addr_t type), which each arch selects (or not) accordingly. Perhaps architectures already selecting 64BIT wouldn't need to do this explicitly, and instead 64BIT could select the new setting (or the new setting could default to Y when 64BIT=y). Jan
