On 17.01.23 15:02, Julien Grall wrote:
Hi Juergen,

On 17/01/2023 09:11, Juergen Gross wrote:
+static void fire_special_watches(const char *name)
+{
+    void *ctx = talloc_new(NULL);
+    struct node *node;
+
+    if (!ctx)
+        return;
+
+    node = read_node(NULL, ctx, name);
+
+    if (node)
+        fire_watches(NULL, ctx, name, node, true, NULL);
+    else
+        syslog(LOG_ERR, "special node %s not found\n", name);

NIT: How about using log() so it is also printed in the trace log? This would be handy to avoid having to check multiple log files.

This would require to move patch 14 in front of this one.

I think this is possible without problems.


With or without:

Reviewed-by: Julien Grall <jgr...@amazon.com>

Thanks,


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to