On 06.01.2023 01:55, Andrew Cooper wrote: > On 05/01/2023 3:59 pm, Jan Beulich wrote: >> Rather than doing a separate hash walk (and then even using the vCPU >> variant, which is to go away), do the up-pointer-clearing right in >> sh_unpin(), as an alternative to the (now further limited) enlisting on >> a "free floating" list fragment. This utilizes the fact that such list >> fragments are traversed only for multi-page shadows (in shadow_free()). >> Furthermore sh_terminate_list() is a safe guard only anyway, which isn't >> in use in the common case (it actually does anything only for BIGMEM >> configurations). >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Acked-by: Andrew Cooper <andrew.coop...@citrix.com>
Thanks. > I think. The reasoning seems plausible, but it would probably benefit > from someone else double checking. Okay, I'll wait some to see whether Tim or George may voice a view. Perhaps until the end of this week, committing early next week if no contrary indications appear. The "good" thing here is that all modern 64-bit guests undergo this transition aiui, so the code is / will be properly exercised. Jan
