On 05/01/2023 2:01 pm, Jan Beulich wrote: > On 22.12.2022 23:31, Demi Marie Obenour wrote: >> --- a/xen/arch/x86/mm.c >> +++ b/xen/arch/x86/mm.c >> @@ -6352,6 +6352,11 @@ unsigned long get_upper_mfn_bound(void) >> return min(max_mfn, 1UL << (paddr_bits - PAGE_SHIFT)) - 1; >> } >> >> + >> +/* > Nit: Please avoid introducing double blank lines. > >> + * A bunch of static assertions to check that the XEN_MSR_PAT is valid >> + * and consistent with the _PAGE_* macros, and that _PAGE_WB is zero. > This comment is too specific for a function of ... > >> + */ >> static void __init __maybe_unused build_assertions(void) > ... this name, in this file.
IMO, you really don't need to comment build_assertions(). It's a pattern we use elsewhere, and the BUILD_BUG_ON()'s are individually commented. I'd just drop this hunk entirely. ~Andrew
