On Tue, 3 Jan 2023, Michal Orzel wrote:
> Printing memory size in hex without 0x prefix can be misleading, so
> add it. Also, take the opportunity to adhere to 80 chars line length
> limit by moving the printk arguments to the next line.
>
> Signed-off-by: Michal Orzel <michal.or...@amd.com>
> ---
> Changes in v2:
> - was: "Print memory size in decimal in construct_domU"
> - stick to hex but add a 0x prefix
> - adhere to 80 chars line length limit
Honestly I prefer decimal but also hex is fine. I'll let Julien pick the
version of this patch that he prefers.
> ---
> xen/arch/arm/domain_build.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 829cea8de84f..f35f4d24569c 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -3774,7 +3774,8 @@ static int __init construct_domU(struct domain *d,
> if ( rc != 0 )
> return rc;
>
> - printk("*** LOADING DOMU cpus=%u memory=%"PRIx64"KB ***\n",
> d->max_vcpus, mem);
> + printk("*** LOADING DOMU cpus=%u memory=%#"PRIx64"KB ***\n",
> + d->max_vcpus, mem);
>
> kinfo.vpl011 = dt_property_read_bool(node, "vpl011");
>
> --
> 2.25.1
>
