Hi Jan,
On 20/12/2022 15:08, Jan Beulich wrote:
On 16.12.2022 12:48, Julien Grall wrote:
From: Wei Liu <wei.l...@citrix.com>
After the direct map removal, pages from the boot allocator are not
mapped at all in the direct map. Although we have map_domain_page, they
Nit: "will not be mapped" or "are not going to be mapped", or else this
sounds like there's a bug somewhere.
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -870,6 +870,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
unsigned long eb_start, eb_end;
bool acpi_boot_table_init_done = false, relocated = false;
int ret;
+ bool vm_init_done = false;
Can this please be grouped with the other bool-s (even visible in context)?
This can't fit on the same line. So I went with:
bool acpi_boot_table_init_done = false, relocated = false;
bool vm_init_done = false;
I prefer this over the below:
bool acpi_boot_table_init_done = false, relocated false,
vm_init_done = false;
Cheers,
--
Julien Grall
