On 15.12.2022 00:11, Demi Marie Obenour wrote: > --- a/xen/arch/x86/include/asm/x86-defns.h > +++ b/xen/arch/x86/include/asm/x86-defns.h > @@ -153,4 +153,15 @@ > (1u << X86_EXC_AC) | (1u << X86_EXC_CP) | \ > (1u << X86_EXC_VC) | (1u << X86_EXC_SX)) > > +/* Memory types */ > +#define X86_MT_UC 0x00 /* uncachable */ > +#define X86_MT_WC 0x01 /* write-combined */ > +#define X86_MT_RESERVED_1 0x02 /* reserved */ > +#define X86_MT_RESERVED_2 0x03 /* reserved */
As said, unless there's a good reason to use 1 and 2 (and not e.g. 0 and 1), I'd prefer these to be numbered 2 and 3 to match the values they expand to (and the numbering then not being as arbitrary). Jan
