On 24.11.2022 17:42, Anthony PERARD wrote:
> Use actual include directory used to install the public header in
> COPYING file.
>
> Also, move the input file out of "tools/include/xen/" because that
> directory is removed on `make clean`.
>
> We can't used ./configure because $includedir contain another
> variable, so the change is done in Makefile.
>
> Fixes: 4ea75e9a9058 ("Rework COPYING installed in /usr/include/xen/, due to
> several licences")
> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com>
(with a question, perhaps just for my own education, at the end)
> ---
>
> Notes:
> For 4.17 inclusion:
>
> Doing `make clean && make` in the root dir is going to fail as make
> isn't going to find the COPYING file while trying to install the
> includes.
I second this would better be fixed for the release.
> --- a/tools/include/Makefile
> +++ b/tools/include/Makefile
> @@ -24,6 +24,7 @@ xen-foreign:
> xen-dir:
> mkdir -p xen/libelf acpi
> find xen/ acpi/ -type l -exec rm '{}' +
> + sed -e 's#@includedir@#$(includedir)/xen#g' xen.COPYING.in > xen/COPYING
Any particular reason for using -e here?
Jan
