Re: [PATCH 0/2] x86/xen: Fix memory leak issue

[Juergen Gross]

On 19.11.22 09:59, Xiu Jianfeng wrote:

The new string allocated by kasprintf() is leaked on error path

Xiu Jianfeng (2):
   x86/xen: Fix memory leak in xen_smp_intr_init{_pv}()
   x86/xen: Fix memory leak in xen_init_lock_cpu()

  arch/x86/xen/smp.c      | 16 ++++++++++++----
  arch/x86/xen/smp_pv.c   |  8 ++++++--
  arch/x86/xen/spinlock.c |  3 ++-
  3 files changed, 20 insertions(+), 7 deletions(-)

Hmm, I think it would make more sense to always store the name generated
via kasprintf() in the percpu variable (independently from succeeding to
bind the irq), and in the related free function to always kfree() it and
set it to NULL again.

This would result in less code.


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature