Hi Andrew,
> -----Original Message-----
> Subject: Re: [PATCH 1/2] tools/libxl: Fixes to
> libxl__domain_set_paging_mempool_size()
>
> On Mon, Nov 21, 2022 at 02:37:30PM +0000, Andrew Cooper wrote:
> > The error message accidentally printed the bytes value as if it were kB.
> >
> > Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t,
> meaning
> > there is a risk of overflow if the user specified a stupidly large value in
> > the vm.cfg file. Check and reject such a condition.
> >
> > Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op;
> use p2m mempool hypercalls")
> > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> > ---
> >
> > v2:
> > * Retain PRIu64
> > * Check for overflow
> >
> > For 4.17. This is a low risk change, removes one overflow case, and makes
> an
> > error message accurate.
>
> Reviewed-by: Anthony PERARD <anthony.per...@citrix.com>
Release-acked-by: Henry Wang <henry.w...@arm.com>
Kind regards,
Henry
