> On 8 Nov 2022, at 15:34, Edwin Török <edvin.to...@citrix.com> wrote:
> 
> Helps debug fatal errors during live update
> 
> Previously this would've just gone to /dev/null, because:
> * daemonize reopens stderr as /dev/null
> * systemd redirects stderr to /dev/null too
> 
> Previously the only way to debug this was to manually run oxenstored with
> --no-fork, but when you have a fatal error and oxenstored just
> disappears you'd want to know why.
> There has been at least one observed instance of a bug where oxenstored
> just disappeared inexplicably (it was believed due to an OOM exception).
> 
> Signed-off-by: Edwin Török <edvin.to...@citrix.com>
> ---
> Reason for inclusion in 4.17:
> - avoids losing crucial information during a fatal error (e.g. during
>  live update)

Acked-by: Christian Lindig <christian.lin...@citrix.com>

> +let print_flush msg =
> +  prerr_endline msg;
> +  flush stderr

The flush is not required because prerr_endline does it implicitly.


Reply via email to