On 02/11/2022 15:14, Anthony PERARD wrote: > On Wed, Nov 02, 2022 at 12:24:21PM +0000, Andrew Cooper wrote: >> On 02/11/2022 11:28, Anthony PERARD wrote: >>> Notes: >>> Maybe instead of this, we should just stamp this on the generated header >>> /* SPDX-License-Identifier: MIT */ >>> >>> but we would be missing the "Copyright" informations. I guess we could >>> look for those line with Copyright and copy them. >>> >>> Or, we could replace the licence in the input header by a SPDX and have >>> the script parse that. (Probably still need to grab the Copyright lines) >> All public headers (except one :-( ) are MIT. >> >> We should SPDX the lot, not least because that removes all the >> guestimation from this script; we can require that the SPDX line is the >> first line, and sanity check it as we process it. > Yes, but I'm not sure I want to do the SPDX change when the tree is > supposed to be frozen.
The licensing corrections are a release blocker. The frozenness of the tree has no bearing on the acceptableness of the fix. Especially when all we're talking about is adjustment of some (legally-relevant) comments. In this case, switching to a more machine-parsable form, in order to get the autogeneration correct, is IMO fully acceptable even at this point in the release. ~Andrew
