> On 1 Nov 2022, at 17:59, Edwin Török <edvin.to...@citrix.com> wrote: > > > Edwin Török (2): > xenctrl.ml: make domain_getinfolist tail recursive > xenctrl: use larger chunksize in domain_getinfolist > > tools/ocaml/libs/xc/xenctrl.ml | 25 ++++++++++++++++++------- > 1 file changed, 18 insertions(+), 7 deletions(-)
Acked-by: Christian Lindig <christian.lin...@citrix.com> > It was calling the Xen domainfolist hypercall N/2 times. > Optimize this such that it is called at most 2 times during normal use. > > Implement a tail recursive `rev_concat` equivalent to `concat |> rev`, > and use it instead of calling `@` multiple times. Are there any assurances about the order in elements returned by domain_getinfolist? I understand that the change maintains the current behaviour but are we even required to maintain that order? Because otherwise we could return the reverse list and save more work. — C
