Hi Jan and Wei, > -----Original Message----- > Subject: Re: [PATCH v6 2/6] xen/x86: move generically usable NUMA code > from x86 to common > > On 11.10.2022 13:17, Wei Chen wrote: > > v5 -> v6: > > 1. Replace numa_scan_node to numa_process_nodes in commit log. > > 2. Limit the scope of page_num_node, vnuma and page of numa_setup > > function. > > 3. Use memset to init page_num_node instead of for_each_online_node. > > 4. Use %u instead of %d for nodeid_t and j in numa_setup print > > messages. > > The only instances of nodeid_t typed variable uses that I was able to > find are in dump_numa(). I guess you can leave them that way, but > strictly speaking %u isn't correct to use for nodeid_t (as it promotes > to int, not to unsigned int).
Sorry for suddenly jumping into the discussion. Firstly thanks Jan for the review :)) I am a little bit confused here, nodeid_t is defined as: typedef u8 nodeid_t; so I think here %u should be probably fine (I may have missed something though)? Kind regards, Henry
