>>> On 21.02.18 at 22:46, <wei.l...@citrix.com> wrote: > Move and rename update_paging_mode. Create a local header file for > this and other functions that need exporting.
Functions you move into global name space need suitable prefixes - neither hvm_update_paging_mode() nor set_iommu_pde_present() clarify that this is AMD IOMMU specific code. Also please don't have bool_t or things like u32 in new code you add (here: the set_iommu_pde_present() prototype). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
