On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote: > From: Anthony PERARD <anthony.per...@citrix.com> > > Xen libraries in 4.10 include a new xentoolcore library. This > contains the xentoolcore_restrict_all function which we are about to > want to use. > > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > Acked-by: Stefano Stabellini <sstabell...@kernel.org> > --- > v5: More truthful commit message. > --- > configure | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index 0a19b03..f580255 100755 > --- a/configure > +++ b/configure > @@ -2188,7 +2188,7 @@ if test "$xen" != "no" ; then > $($pkg_config --modversion xencontrol | sed 's/\./ /g') )" > xen=yes > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab" > - xen_pc="$xen_pc xenevtchn xendevicemodel" > + xen_pc="$xen_pc xenevtchn xendevicemodel xentoolcore"
I think we want to check if "xentoolcore" pkg_config exist before trying to use it. Otherwith, that is not going to work with Xen older than 4.10. `pkg-config --libs` will throw an error without printing anything if one of the library doesn't exist. Instead, we could do this: if $pkg_config --exists xentoolcore; then xen_pc+=" xentoolcore" fi > QEMU_CFLAGS="$QEMU_CFLAGS $($pkg_config --cflags $xen_pc)" > libs_softmmu="$($pkg_config --libs $xen_pc) $libs_softmmu" > LDFLAGS="$($pkg_config --libs $xen_pc) $LDFLAGS" -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
