On 19.09.2022 17:09, Marek Marczykowski-Górecki wrote: > --- a/xen/common/sched/credit2.c > +++ b/xen/common/sched/credit2.c > @@ -996,9 +996,13 @@ cpu_add_to_runqueue(const struct scheduler *ops, > unsigned int cpu) > * > * Otherwise, let's try to make sure that siblings stay in the > * same runqueue, pretty much under any cinrcumnstances. > + * > + * Furthermore, try to respect credit2_runqueue=all, as long as > + * max_cpus_runq isn't violated.
This last part is questionable, partly because the command line doc is ambiguous as to which of the two options is intended to "win". I guess one needs to know the original intentions to resolve this. > */ > if ( rqd->refcnt < max_cpus_runq && (ops->cpupool->gran != > SCHED_GRAN_cpu || > - cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq)) ) > + cpu_runqueue_siblings_match(rqd, cpu, max_cpus_runq) || > + opt_runqueue == OPT_RUNQUEUE_ALL) ) Indentation was already broken here. As you're touching it, may I ask that you correct that aspect? Jan
