On Mon, Sep 19, 2022 at 01:02:52PM +0200, Jan Beulich wrote:
> On 19.09.2022 12:28, Anthony PERARD wrote:
> 
> Acked-by: Jan Beulich <jbeul...@suse.com>
> with a remark and one more adjustment:
> 
> > ---
> > 
> > Notes:
> >     v3:
> >     - back to using common-stub.c
> 
> As said in person, I'm a little puzzled by this, as the v2 discussion
> had no hint in that direction.

I think it's because the discussion continued on V1, and I mostly follow
that:
    
https://lore.kernel.org/xen-devel/5d926715-b6af-234f-9798-622cdb53f...@xen.org/

> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -280,6 +280,7 @@ xen/arch/*/efi/ebmalloc.c
> >  xen/arch/*/efi/efi.h
> >  xen/arch/*/efi/pe.c
> >  xen/arch/*/efi/runtime.c
> > +xen/arch/*/efi/common-stub.c
> >  xen/arch/*/include/asm/asm-offsets.h
> >  xen/common/config_data.S
> >  xen/common/config.gz
> 
> The new line wants inserting a few lines further up, to retain sorting.

Oops, forgot to re-sort after renaming from "stub" to "common-stub".

> Can perhaps be done while committing.

Thanks,

-- 
Anthony PERARD

Reply via email to