On Tue, Sep 13, 2022 at 01:54:12PM +0100, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH] libvirt: disable Werror for non-libvirt
> flights"):
> > Current usage of Werror=switch-enum by default for libvirt builds out
> > of the git tree causes issues when new items are added to libxl public
> > API enums if those are used in a switch statement in libvirt code.
> > This leads to libvirt build failures for seemingly unrelated libxl
> > changes.
> >
> > In order to prevent those errors from blocking the push gate, disable
> > Werror for libvirt builds when not in a libvirt specific flight.
> >
> > The errors will be reported on the libvirt flight, and block the
> > pushes there. So the author of the changes in libxl is still expected
> > to send a fix to libvirt code. This is no ideal, but the other option
> > is to just disable Werror for all libvirt builds and let libvirt
> > developers fix the breakage when they notice it.
> ..
> > +build-i386-libvirt autogen_options
> > --disable-werror
>
> We have no way to specify -Wno-error-switch-enum specifically ?
> (I'm not sure if that would be desirable.)
Hm, maybe playing with CFLAGS, but not from the autogen/meson options
AFAIK. Using the autogen/meson flags seems cleaner and less error
prone (albeit the disabling of Werror is more wide than what we
strictly require).
> > I'm unsure whether we want o disable Werror even for libvirt flights,
> > but this seems more conservative.
>
> Probably disabling it only for Xen is right.
Thanks, let's try this first then.
Roger.
