Hi Stefano, > -----Original Message----- > From: Stefano Stabellini <[email protected]> > Subject: Re: [PATCH v2 1/4] docs, xen/arm: Introduce reserved heap memory > > On Mon, 5 Sep 2022, Henry Wang wrote: > > This commit introduces the reserved heap memory, which is parts of RAM > > reserved in the beginning of the boot time for heap. > > > > Firstly, since a new type of memory bank is needed for marking the > > memory bank solely as the heap, this commit defines `enum > membank_type` > > and use this enum in function device_tree_get_meminfo(). Changes of > > code are done accordingly following the introduction of this enum. > > > > Also, this commit introduces the logic to parse the reserved heap > > configuration in device tree by reusing the device tree entry definition > > of the static memory allocation feature. If the memory bank is reserved > > as heap through `xen,static-heap` property in device tree `chosen` node, > > the memory will be marked as heap type. > > > > A documentation section is added, describing the definition of reserved > > heap memory and the method of enabling the reserved heap memory > through > > device tree at boot time. > > > > Signed-off-by: Henry Wang <[email protected]> > > Signed-off-by: Penny Zheng <[email protected]> > > I think the device tree interface is good and you can consider it acked > by me. I'll let you follow up on the other comments by others on the > code changes.
Thanks, I will fix the comments from Michal and Julien. Kind regards, Henry
