Hi,
On 05/09/2022 14:36, Rahul Singh wrote:
Please have a look once if this looks okay.
/*
* List of possible features for dom0less domUs
*
* DOM0LESS_ENHANCED_BASIC: Notify the OS it is running on top of Xen. All
the
* default
features (excluding Xenstore) will be
* available. Note
that an OS *must* not rely on the
* availability of
Xen features if this is not set.
* DOM0LESS_XENSTORE: Xenstore will be enabled for the VM.
This feature
* can't be
enabled without the DOM0LESS_ENHANCED_BASIC.
* DOM0LESS_ENHANCED: Notify the OS it is running on top of
Xen. All the
* default
features (including Xenstore) will be
* available. Note
that an OS *must* not rely on the
* availability of
Xen features if this is not set.
*/
#define DOM0LESS_ENHANCED_BASIC BIT(0, UL)
#define DOM0LESS_XENSTORE BIT(1, UL)
#define DOM0LESS_ENHANCED (DOM0LESS_ENHANCED_BASIC |
DOM0LESS_XENSTORE)
The explanation looks good to me but the indentation looks odd. Also, I
think it would be preferable to use U or ULL (if you want 64 bits) so
the size of the bitfield is not arch depending.
Cheers,
--
Julien Grall
