On 05/09/2022 08:00, Juergen Gross wrote:
> @@ -3312,17 +3325,18 @@ void free_cpu_rm_data(struct cpu_rm_data *mem,
> unsigned int cpu)
> * The cpu is already marked as "free" and not valid any longer for its
> * cpupool.
> */
> -int schedule_cpu_rm(unsigned int cpu)
> +int schedule_cpu_rm(unsigned int cpu, struct cpu_rm_data *data)
> {
> struct sched_resource *sr;
> - struct cpu_rm_data *data;
> struct sched_unit *unit;
> spinlock_t *old_lock;
> unsigned long flags;
> int idx = 0;
> unsigned int cpu_iter;
> + bool freemem = !data;
v4 is much clearer to follow than v3. One final suggestion, having read
through the series again; rename this to free_data so as to relate more
closely to what it does.
I can fix on commit if you're happy.
Everything A/T-by Andrew Cooper <[email protected]>
~Andrew