On 12.08.2022 21:24, Julien Grall wrote: > From: Julien Grall <jgr...@amazon.com> > > At the moment, the strings are in text right after each use because > the instruction 'adr' has specific requirement on the location > and the compiler will forbid cross section label. > > The macro 'adr_l' was recently reworked so the caller doesn't need > to know whether the MMU is on. This makes it easier to use where > instructions can be run in both context. > > This also means that the strings don't need to be part of .text > anymore. So move them to .rodata.str.
Wouldn't they better live somewhere in .init* ? > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -93,13 +93,10 @@ > */ > #define PRINT(_s) \ > mov r3, lr ;\ > - adr r0, 98f ;\ > + adr_l r0, 98f ;\ > bl puts ;\ > mov lr, r3 ;\ > - b 99f ;\ > -98: .asciz _s ;\ > - .align 2 ;\ > -99: > + RODATA_STR(98, _s) Nit: How about using uniform indentation here and ... > @@ -736,7 +733,7 @@ ENDPROC(puts) > * Clobbers r0-r3 > */ > putn: > - adr r1, hex > + adr_l r1, hex > mov r3, #8 > 1: > early_uart_ready r11, r2 > @@ -749,8 +746,7 @@ putn: > mov pc, lr > ENDPROC(putn) > > -hex: .ascii "0123456789abcdef" > - .align 2 > +RODATA_STR(hex, "0123456789abcdef") ... here? Jan
