Hi Jan,
On 8/5/22 15:50, Jan Beulich wrote:
On 05.08.2022 14:44, Xenia Ragiadakou wrote:
Xenia Ragiadakou (3):
xen/cpu: Fix MISRA C 2012 Rule 20.7 violation
xen/cpu: Add missing white space around arithmetic operators
xen/cpu: Undefine MASK_DECLARE_ macros after their usage
xen/common/cpu.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
Acked-by: Jan Beulich <jbeul...@suse.com>
However,
- I don't see why patches 1 and 2 needed splitting, when patch 1 already
touches all those lines. It is the usual thing for us to make cosmetic
adjustments when touching a line anyway.
In my opinion, the initial patch that added the code should not have
been accepted in first place without the white spaces around '+'.
But maybe coding style rules came later.
Nevertheless, I continue to consider it unfair to rely on and request
from new unrelated patches to fix those issues.
- Patch 3, while fine to be separate, wants a Requested-by: or
Suggested-by: me (which I guess can be taken care of while committing).
Jan
--
Xenia
