>>> On 04.04.18 at 01:01, <janakarajan.natara...@amd.com> wrote: > Adding new key-handler "j" for dumping AVIC-related information.
Considering how few keys we have left, I have significant reservations against adding such a narrow purpose key. If you really want to expose such information, add it to a suitable existing key or introduce a sysctl. > --- a/xen/arch/x86/hvm/svm/avic.c > +++ b/xen/arch/x86/hvm/svm/avic.c > @@ -28,6 +28,7 @@ > #include <asm/hvm/support.h> > #include <asm/hvm/svm/avic.h> > #include <asm/hvm/vlapic.h> > +#include <xen/keyhandler.h> > #include <asm/p2m.h> > #include <asm/page.h> Please insert new includes in a more logical manner (where possible we ask for them to be sorted alphabetically, but that may not make sense here, but at least group it with other xen/ ones). > @@ -49,6 +50,11 @@ > */ > bool svm_avic = 0; > > +static inline bool svm_is_avic_domain(struct domain *d) const > +{ > + return ( d->arch.hvm_domain.svm.avic_physical_id_table != 0 ); Stray blanks (and unnecessary parentheses anyway). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel